Skip to content

Fix movement on hover when only links. #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025
Merged

Conversation

akademy
Copy link
Member

@akademy akademy commented Apr 4, 2025

The menu items would move up and down when there's only the links set. This is a fix for that.

Also, some changes to add to centre the menu (so it's more like a traditional footer!).

And a little refactor of the storybook file.

@akademy akademy requested review from VictoriaBeilsten-Edmands and RhysMAdey and removed request for VictoriaBeilsten-Edmands April 4, 2025 15:50
@RhysMAdey
Copy link
Contributor

Would we want the links centred like the copyright info?

Screenshot From 2025-04-07 15-13-57

@akademy akademy force-pushed the jmbw/fix-footer-display branch from 60ef617 to afa1a6b Compare April 7, 2025 16:04
@akademy
Copy link
Member Author

akademy commented Apr 7, 2025

Would we want the links centred like the copyright info?

Screenshot From 2025-04-07 15-13-57

Should be fixed in latest version.

…re links. Align links with copyright.

Make alignment easier in Storyboard view by adding transparent color.
@akademy akademy force-pushed the jmbw/fix-footer-display branch from afa1a6b to ccc5f31 Compare April 8, 2025 10:17
@akademy akademy merged commit 4edfd4f into main Apr 8, 2025
1 check passed
@akademy akademy deleted the jmbw/fix-footer-display branch April 8, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants